Fix/check requirements debug#72
Open
Kronk74 wants to merge 3 commits into
Open
Conversation
jfroment
reviewed
Jan 14, 2025
| exit 1 | ||
| fi | ||
| echo "[$0] ***** Checking required tools... *****" | ||
| REQUIRED_TOOLS=("docker" "docker compose" "yq" "jq") |
Owner
There was a problem hiding this comment.
Some installations use "docker-compose" v2 binary, so the naming may be wrong here if someone's using "docker-compose" instead of "docker compose".
Maybe we should enforce versions checks only for yq and jq for the time being.
Owner
There was a problem hiding this comment.
In fact we could load the env var $DOCKER_COMPOSE_BINARY (which is defined in .env) to determine it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I had an issue in my server and it was due to yq version... If yq is installed but not with the good version, the script is doing nothing.
Here is a purpose to check better this requirements.
See you,