fix: plugin owns TabLine* highlight groups; add vimrc integration boundary doc#8
Merged
Conversation
…ndary doc - Add tabline/tabline_sel/tabline_fill keys to g:tabs_vim_colors with Dracula defaults so the plugin fully owns the tab bar appearance - Apply TabLine, TabLineSel, TabLineFill hi groups in s:ApplyColors() - Update spec and ADR-002 to document the expanded color config contract - Add Vimrc Integration Boundary design pattern to spec - Mark completed features in spec; align Features table to template format Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR expands tabs.vim theming so the plugin explicitly applies Vim’s standard TabLine* highlight groups in addition to its existing TabsVim_* groups, and updates the spec/ADR to document the broader g:tabs_vim_colors contract and a “vimrc integration boundary” pattern.
Changes:
- Add
tabline,tabline_sel, andtabline_fillkeys (with Dracula defaults) tog:tabs_vim_colors, and apply them ins:ApplyColors(). - Update the spec and ADR-002 to reflect the expanded color configuration surface and document the integration boundary pattern.
- Refresh spec metadata and align the Features table format/statuses.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| skills-lock.json | Updates computed hash for the local skill source. |
| plugin/tabs.vim | Adds default colors + highlight application for TabLine, TabLineSel, TabLineFill. |
| docs/specs/tabs.vim.md | Documents new color keys and adds “Vimrc Integration Boundary”; updates Features table. |
| docs/adrs/002.tabs-vim.themes.md | Expands ADR scope from mode colors to all tab bar colors, including TabLine*. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TabLine,TabLineSel,TabLineFillhighlight groups are applied bys:ApplyColors()alongside the existingTabsVim_*groups — no separatehideclarations needed in the user's vimrcg:tabs_vim_colors:tabline,tabline_sel,tabline_fill(with Dracula defaults), overridable like all other color keysg:tabs_vim_colorsTest plan
TabLine,TabLineSel,TabLineFillare set without anyhiin vimrctabline/tabline_sel/tabline_fillviag:tabs_vim_colorsand confirm they apply