feat: make mode colors user-configurable via g:tabs_vim_colors#7
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds a user-facing theming contract so mode “pill” highlight colors can be configured via g:tabs_vim_colors, while keeping Dracula as the default palette.
Changes:
- Replaces hardcoded
histatements with ans:ApplyColors()function driven by a defaults dict and optional user overrides. - Documents the configuration contract and partial override example in the spec.
- Adds ADR-002 capturing the theming decision and alternatives considered.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
plugin/tabs.vim |
Introduces defaults + s:ApplyColors() to generate highlight groups from merged config. |
docs/specs/tabs.vim.md |
Specifies g:tabs_vim_colors contract, defaults, and partial override example. |
docs/adrs/002.tabs-vim.themes.md |
ADR documenting the chosen theming configuration approach and tradeoffs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
histatements with as:ApplyColors()function driven by a defaults dictg:tabs_vim_colorsin their vimrc; unspecified modes fall back to Dracula defaultsContract
Test plan
g:tabs_vim_colorsset — Dracula defaults apply unchangednormal) — overridden mode changes, others keep defaults