Skip to content

Add settings for proxy with authentication#106

Open
Beutlin wants to merge 1 commit into
jesperfj:masterfrom
Beutlin:master
Open

Add settings for proxy with authentication#106
Beutlin wants to merge 1 commit into
jesperfj:masterfrom
Beutlin:master

Conversation

@Beutlin

@Beutlin Beutlin commented Dec 27, 2024

Copy link
Copy Markdown

In enterprise companies, proxies might be neeed to talk to foreign websites.
This pull request adds proxy settings in the current library. Furthermore it allows user + password protected proxies.

@MarcelEdmundFranke

Copy link
Copy Markdown

Hi @jesperfj, Do you have any plans to merge this soon? I urgently need this feature.

@jesperfj

Copy link
Copy Markdown
Owner

I always completely ignore PRs with no or insufficient description.

@Beutlin

Beutlin commented Feb 26, 2025

Copy link
Copy Markdown
Author

@jesperfj how can I contact you? I saw 1 PR like mine and you reflected out because there haven't been any test.
But testing proxies is not easy, as I don't know which proxy you want to use in your automated tests.

@jesperfj

jesperfj commented Feb 26, 2025 via email

Copy link
Copy Markdown
Owner

@Beutlin

Beutlin commented Feb 27, 2025

Copy link
Copy Markdown
Author

I've updated the description and hope that makes the intention of this PR clearer.
If you need also a bug/feature request ticket, I will open it as well.

@jesperfj

Copy link
Copy Markdown
Owner

I tried to get my test setup working but it's simply become too hard and cumbersome to maintain even the most basic working tests. Mostly because I stopped using Salesforce a long time ago myself so I am not keeping up with changes.

I am afraid this repo will no longer get even simple upgrades unless someone can help come up with a way of running the test suite against a reasonably stable test org setup.

@Beutlin

Beutlin commented Mar 24, 2025

Copy link
Copy Markdown
Author

Thank you for your efforts for this great library.
Of course I can understand your reasons.
If it is only the missing Salesforce account, you could create a free developer edition account, which is valid for 180 days after last login. That allows to run tests.
A real test with proxy settings is a bit more difficult. I've used a simple-proxy to pass requests on my machine through it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants