[JENKINS-54514] Document error handling in the 'parallel' step#260
Open
ringerc wants to merge 2 commits into
Open
[JENKINS-54514] Document error handling in the 'parallel' step#260ringerc wants to merge 2 commits into
ringerc wants to merge 2 commits into
Conversation
jglick
changed the title
Contributor
Author
|
The checks failed due to what appears to be network issues with the Windows builder. |
jglick
approved these changes
Apr 4, 2019
Contributor
|
@ringerc What do you think of the suggestions? |
Contributor
Author
|
I appreciate the review and will merge the changes and update the PR
shortly. I've been swamped at work.
…On Sat, 15 Jun 2019 at 07:43, Liam Newman ***@***.***> wrote:
@ringerc <https://github.com/ringerc> What do you think of the
suggestions?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#260?email_source=notifications&email_token=AACC7IMVFFTTKTFGTYI4MGLP2QUKVA5CNFSM4GCJZWIKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXYK2VA#issuecomment-502312276>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AACC7IJFGHBBTIKEDW33G3TP2QUKVANCNFSM4GCJZWIA>
.
--
Craig Ringer http://www.2ndQuadrant.com/
2ndQuadrant - PostgreSQL Solutions for the Enterprise
|
Contributor
|
@ringerc Any update here? I'd apply the commits myself but I don't have permissions. I'd like to be able to merge this change. |
|
@ringerc @bitwiseman It looks like this has been lost in time. |
dwnusbaum
suggested changes
Jun 18, 2020
dwnusbaum
left a comment
dwnusbaum
left a comment
Member
There was a problem hiding this comment.
Added some comments. It would be great to also apply Jesse's comments/suggestions.
| <code>Throwable.addSuppresssed(...)</code>. | ||
| </p> | ||
| <p> | ||
| Note that a <code>hudson.AbortException</code>, as thrown by failing |
Member
There was a problem hiding this comment.
AbortException is not necessarily thrown by failing steps.
I think mentioning AbortException is misleading since it doesn't have any special interaction with the parallel step.
| the first failed script. | ||
| </p> | ||
| <p> | ||
| Note: Branch closures should just return <code>null</code>. The return |
Member
There was a problem hiding this comment.
I would move this paragraph above the preceding one, and reword it slightly. Since we don't want anyone to rely on the current behavior I think it is best not to mention what that behavior is directly.
Note: Branch closures should just return <code>null</code>. The return
value of the <code>parallel</code> step should be ignored; See JENKINS-26033.
Co-authored-by: Jesse Glick <jglick@cloudbees.com> Co-authored-by: Devin Nusbaum <dwnusbaum@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JENKINS-54514