Finalize recovered CPS executions with no threads#1793
Open
AnantSingh1510 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle an unrecoverable Pipeline state where a
CpsFlowExecutionis restored with no CPS threads while its flow graph is still non-terminal.When this happens, there is nothing for Pipeline to resume or interrupt, but the owning
WorkflowRuncan still remain marked as building. Treat an empty restoredCpsThreadGroupon a non-complete execution as a program load failure, so the existing recovery path finalizes the run asFAILUREinstead of leaving it stuck.This also moves the
done = trueassignment in placeholder node creation until after the fallback nodes/actions are created, avoiding action persistence warnings on that path.Fixes #1792
Testing done
Added
PersistenceProblemsTest#inProgressWithStepEndHeadButNoCpsThreads.The test creates the persisted state directly:
StepEndNode.WorkflowRuncompletion/result state.CpsThreadGrouptoprogram.dat.FAILURE.Ran locally:
Result:
Related pull requests: none.
Submitter checklist