Skip to content

Added interactive navigations to quickly find failed tests and reasons#38

Open
judovana wants to merge 1 commit into
jenkinsci:masterfrom
judovana:hidePassesNw1
Open

Added interactive navigations to quickly find failed tests and reasons#38
judovana wants to merge 1 commit into
jenkinsci:masterfrom
judovana:hidePassesNw1

Conversation

@judovana

@judovana judovana commented Apr 29, 2024

Copy link
Copy Markdown
  • possibility to hide/show
    • passed/failed/ignored/bailed out tests
    • diagnostic details
    • individual diagnostic items
    • the three state buttons can control individual items
    • several preset views to mimic the major workflows
  • number is now direct url to itself

precautions against CVE 3190 should be applied
tested in firefox and chromium

rebased #29

@judovana

Copy link
Copy Markdown
Author

The newest test fails for me:

[INFO] 
[INFO] Results:
[INFO] 
[ERROR] Errors: 
[ERROR]   TestXssTapFile.testTapFileXss:108 » Script missing formal parameter (http://localhost:46801/jenkins/plugin/tap/interactive.js#311)
[INFO] 
[ERROR] Tests run: 48, Failures: 0, Errors: 1, Skipped: 0
[INFO] 

I was unable to make it run. Any advice welcomed. And maybe it will pass here in GH actions

@judovana

Copy link
Copy Markdown
Author

Same failure in CI. It seems https://github.com/judovana/tap-plugin/blob/bddc3aa78250ec84bedd1204a1ea54a17e516511/src/main/webapp/interactive.js#L311 will need some love. Will elaborate (which do not prevent anyone to start reviewing O:)
j.

@judovana

Copy link
Copy Markdown
Author

Same failure in CI. It seems https://github.com/judovana/tap-plugin/blob/bddc3aa78250ec84bedd1204a1ea54a17e516511/src/main/webapp/interactive.js#L311 will need some love. Will elaborate (which do not prevent anyone to start reviewing O:) j.

Actually, function getSelectState(...clazz) { It seems that the in-test-browser can not read this JS syntax:(

@judovana

Copy link
Copy Markdown
Author

Ok, seems the fix was indeed in signature of that method. Test passed for me, and all seems working. But will double check at the morning. Happy hacking!

@judovana

Copy link
Copy Markdown
Author

Hello! There is a month anniversary. Will you be willing to take a look please?

@judovana

Copy link
Copy Markdown
Author

Ping please?

@judovana

Copy link
Copy Markdown
Author

@kinow You there please?

@judovana

judovana commented Aug 2, 2024

Copy link
Copy Markdown
Author

@kinow - As understood in https://issues.jenkins.io/browse/JENKINS-73484 the unittests were blocker of thiis PR. Thus I started adding them. Please, if anyhting is blocking so long, but still live PR, jsut tell WHAT. Silecne wold not help.

I had added basic tests for checking some static changes in code. Will add few more, and then also soem of the JS interactions if I figure how. Please step into rather sooner then later.

@judovana judovana force-pushed the hidePassesNw1 branch 2 times, most recently from 8a1a301 to dd8180e Compare August 4, 2024 10:25
@judovana

judovana commented Aug 4, 2024

Copy link
Copy Markdown
Author

@kinow in this way I can continue to add ny tests you need, but that do not seem exactly right until we have agreement on impl.

The ball is now in your hand.

@smlambert

Copy link
Copy Markdown

I am interested in this enhancement to the tap-plugin, and wondering if there is an ETA for it, or any other concerns before bringing it into the code base?

- possibility to hide/show
   - passed/failed/ignored/bailed out tests
   - diagnosticd details
   - individual diagnostic items
   -  the three state buttons can control individual items
   - several preset views to mimic the major workflows
- number is now direct url to itself

precautions against CVE 3190 should be applied
tested in firefox and chromium
@judovana

Copy link
Copy Markdown
Author

@kinow - san! It is yet again rebased. As I'm moving again to teams which are using tap plugin heavily, and can nto run from random forks, can you please look into that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants