Added interactive navigations to quickly find failed tests and reasons#38
Added interactive navigations to quickly find failed tests and reasons#38judovana wants to merge 1 commit into
Conversation
|
The newest test fails for me: I was unable to make it run. Any advice welcomed. And maybe it will pass here in GH actions |
|
Same failure in CI. It seems https://github.com/judovana/tap-plugin/blob/bddc3aa78250ec84bedd1204a1ea54a17e516511/src/main/webapp/interactive.js#L311 will need some love. Will elaborate (which do not prevent anyone to start reviewing O:) |
Actually, |
|
Ok, seems the fix was indeed in signature of that method. Test passed for me, and all seems working. But will double check at the morning. Happy hacking! |
|
Hello! There is a month anniversary. Will you be willing to take a look please? |
|
Ping please? |
|
@kinow You there please? |
|
@kinow - As understood in https://issues.jenkins.io/browse/JENKINS-73484 the unittests were blocker of thiis PR. Thus I started adding them. Please, if anyhting is blocking so long, but still live PR, jsut tell WHAT. Silecne wold not help. I had added basic tests for checking some static changes in code. Will add few more, and then also soem of the JS interactions if I figure how. Please step into rather sooner then later. |
8a1a301 to
dd8180e
Compare
|
@kinow in this way I can continue to add ny tests you need, but that do not seem exactly right until we have agreement on impl. The ball is now in your hand. |
|
I am interested in this enhancement to the tap-plugin, and wondering if there is an ETA for it, or any other concerns before bringing it into the code base? |
- possibility to hide/show - passed/failed/ignored/bailed out tests - diagnosticd details - individual diagnostic items - the three state buttons can control individual items - several preset views to mimic the major workflows - number is now direct url to itself precautions against CVE 3190 should be applied tested in firefox and chromium
5526c40 to
4b5e9db
Compare
|
@kinow - san! It is yet again rebased. As I'm moving again to teams which are using tap plugin heavily, and can nto run from random forks, can you please look into that? |
precautions against CVE 3190 should be applied
tested in firefox and chromium
rebased #29