Upgrade tests to JUnit5#279
Open
strangelookingnerd wants to merge 4 commits into
Open
Conversation
9038b5b to
d6cb365
Compare
d6cb365 to
1947c0a
Compare
1947c0a to
1cac7f6
Compare
1cac7f6 to
986b8fc
Compare
986b8fc to
06d0548
Compare
Contributor
Author
|
@jenkinsci/scm-api-plugin-developers Kindly requesting a review. |
06d0548 to
519898b
Compare
rsandell
approved these changes
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades all tests to run with JUnit5. Notable changes besides the obvious:
DataPointbasedTheorytests now useParameterizedTestwith aMethodSourceorEnumSourceas appropriate.AbstractSampleRepoRuleandAbstractSampleDVCSRepoRulewere not upgraded as they are used by other plugin. Consequently I left the dependency to JUnit4 inpom.xmlbe. If desired I can look into upgrading them, too.Testing done
Ran
mvn clean verifybefore and after changes. While all are successful, the overall number of reported tests increased from 124 to 135 due to the wayParameterizedTestwork.Submitter checklist