Skip to content

Adding a project name to the job to group them by it, on Radiator View#15

Open
wandenberg wants to merge 1 commit into
jenkinsci:masterfrom
wandenberg:master
Open

Adding a project name to the job to group them by it, on Radiator View#15
wandenberg wants to merge 1 commit into
jenkinsci:masterfrom
wandenberg:master

Conversation

@wandenberg

Copy link
Copy Markdown

If the user want, can set a project name to the job.
Jobs with same project name will be grouped on Radiator View. (updated version of #9 )

@wandenberg

Copy link
Copy Markdown
Author

This pull request add a help message asked on #9. The field order cannot be changed inside the plugin, at least I cannot figure how to do it.

@jenkinsadmin

Copy link
Copy Markdown
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't be touched

@batmat

batmat commented Feb 12, 2016

Copy link
Copy Markdown
Member

Wondering if/why we should better not add a new property and use the standard Display Name.

@wandenberg

Copy link
Copy Markdown
Author

Hi @batmat,

I'm not sure if use the Display Name is a good idea.
The target of this new property is to enable the user to set a Group Name for its projects on radiator view.
The default behavior is to use the prefix of the job name.
So we have three configurations

  • job name -> the identifier for the job
  • display name -> a more beautiful name for the job
  • project name -> the name of the project of which the job make part

What can I do to have this very old pull request accepted?

@ssbarnea

Copy link
Copy Markdown

Sorry for highjacking this but it seems to be related to https://issues.jenkins-ci.org/browse/JENKINS-36320 --- when using GitHub Organisation Folder plugin (part of Jenkins 2 core plugins!) the job names that are detected by Radiator are only the branch names, making it impossible to use.

Is this plugin still maintained? I am asking this because you do not usually see a PR that is open for almost two years.

@batmat

batmat commented Jul 27, 2016

Copy link
Copy Markdown
Member

Yes it is.
@ssbarnea I adopted it some time ago, hence the previously present PR that I started addressing.
But yeah, I should give it a go after my last comment above and the answer.

@ssbarnea

Copy link
Copy Markdown

That really good news! My personal opinion regarding the name is that the visible job name for deep jobs should be something like "orgname/reponame/branchname" as this is simple but complex enough to not allow us to overlap job names that are in different folders.

This also means that if I would move a job from root into a folder named "experimental", the new job name would be "experimental/jobname".

@batmat batmat self-requested a review February 10, 2018 10:29
@batmat

batmat commented Nov 14, 2018

Copy link
Copy Markdown
Member

BTW, for people watching https://issues.jenkins-ci.org/browse/JENKINS-36320 discussed above has been fixed since that comment.

@wandenberg do you still need this given the default naming when using Folders for instance. It tends to make more sense to me that people would group things by folders, and hence you'd get the grouping OOTB this way?

I'm sorry I was unable to push this to completion and not reactive here ealier.

@batmat batmat removed their request for review November 14, 2018 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants