Fix Issue #471#470
Merged
Merged
Conversation
Contributor
Author
|
Testing on our jenkins instance was successful. I consider this pull request ready. If you want me to add new tests, please provide some pointers on what to do |
… Else jenkins nodes cannot be deleted if there is no corresponding instance in the cloud.
… of zombie offline nodes in jenkins that failed to start in the cloud.
Contributor
|
hi @Theoderich, yes adding some tests could be great. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #471
Testing done
Currently testing on self hosted jenkins in our company. Will report back with results
If any automated tests need to be changed to test this behavior, I would appreciate some help
Submitter checklist