Skip to content

Fix Issue #471#470

Merged
batmat merged 2 commits into
jenkinsci:developfrom
qaware:issue-381
Dec 12, 2024
Merged

Fix Issue #471#470
batmat merged 2 commits into
jenkinsci:developfrom
qaware:issue-381

Conversation

@Theoderich

@Theoderich Theoderich commented Sep 6, 2024

Copy link
Copy Markdown
Contributor

fixes #471

  • Check if an instance actually exists in the cloud before trying to delete it
  • Terminate jenkins nodes immediately if the isntance failed to start in the cloud

Testing done

Currently testing on self hosted jenkins in our company. Will report back with results

If any automated tests need to be changed to test this behavior, I would appreciate some help

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@Theoderich Theoderich changed the title Fix Issue #381 Fix Issue #471 Sep 8, 2024
@Theoderich

Copy link
Copy Markdown
Contributor Author

Testing on our jenkins instance was successful. I consider this pull request ready. If you want me to add new tests, please provide some pointers on what to do

@Theoderich Theoderich marked this pull request as ready for review September 13, 2024 08:10
… Else jenkins nodes cannot be deleted if there is no corresponding instance in the cloud.
… of zombie offline nodes in jenkins that failed to start in the cloud.
@Artmorse

Artmorse commented Nov 26, 2024

Copy link
Copy Markdown
Contributor

hi @Theoderich, yes adding some tests could be great.
I'll try to reproduce it and think about how to test it.

@batmat batmat merged commit 5ba199e into jenkinsci:develop Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failing to start an instance in the cloud creates undeletable zombie nodes

3 participants