Skip to content

Refactor Dockerfile#51

Closed
Gauvino wants to merge 2 commits into
jellyfin:masterfrom
Gauvino:master
Closed

Refactor Dockerfile#51
Gauvino wants to merge 2 commits into
jellyfin:masterfrom
Gauvino:master

Conversation

@Gauvino

@Gauvino Gauvino commented Jan 14, 2024

Copy link
Copy Markdown
  • Changed emsdk version to the latest one from 2.0.34 to 3.1.51
  • Re-arranged the package
  • Added clean command

- Changed emsdk version to the latest one from 2.0.34 to 3.1.51
- Re-arranged the package
- Added clean command
@Gauvino

Gauvino commented Feb 6, 2024

Copy link
Copy Markdown
Author

image
Proof of building

@Gauvino

Gauvino commented Feb 29, 2024

Copy link
Copy Markdown
Author

@dmitrylyzo does this PR is needed or can be closed ?

The repo is abandoned ?

@dmitrylyzo

Copy link
Copy Markdown
Collaborator

I don't remember where I stopped.
IIRC, updating Emscripten to latest was causing JSO to not work in older browsers (TV).
Moreover, it requires more changes: master...dmitrylyzo:JavascriptSubtitlesOctopus:update-emscripten

The idea was to update this repo to upstream (as clean as possible, but without unnecessary changes).
One of those updates: #46

10.9 has moved to JASSUB, so this repo has become less relevant.

@Gauvino

Gauvino commented Feb 29, 2024

Copy link
Copy Markdown
Author

I don't remember where I stopped.

IIRC, updating Emscripten to latest was causing JSO to not work in older browsers (TV).

Moreover, it requires more changes: master...dmitrylyzo:JavascriptSubtitlesOctopus:update-

Ok, I didn't see this change.

The idea was to update this repo to upstream (as clean as possible, but without unnecessary changes).

One of those updates: #46

10.9 has moved to JASSUB, so this repo has become less relevant.

So this PR is not needed anymore if this repo is being used this jellyfin switch to jassub

@Gauvino Gauvino closed this Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants