Only append '.json' to output file name if it is not already present#26
Open
beatboxchad wants to merge 2 commits intojekyc:masterfrom
Open
Only append '.json' to output file name if it is not already present#26beatboxchad wants to merge 2 commits intojekyc:masterfrom
beatboxchad wants to merge 2 commits intojekyc:masterfrom
Conversation
gronke
reviewed
Feb 17, 2017
wig/classes/output.py
Outdated
| def write_file(self): | ||
| file_name = self.options['write_file'] | ||
| with open(file_name+ '.json', 'w') as fh: | ||
| file_name = file_name if re.search(r'\.json\s*$', file_name) else file_name + '.json' |
There was a problem hiding this comment.
This and the line above could be simplified to
file_name = re.sub('(\.json)?\s*$', '', self.options['write_file']) + '.json'
Author
There was a problem hiding this comment.
Oh hey, that's very elegant. I'm going to do that now. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python wig.py www.beatboxchad.com -w ~/foo.jsoncreated a file named ~/foo.json.json. Now that's fixed.