Skip to content

Add resizable graph if too many reviewers #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
OxyFlax wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add resizable graph if too many reviewers #27

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8669382
improve display when there are lots of reviewers on the project
Sep 20, 2021
bf03064
Merge pull request #2 from OxyFlax/feature/resizable-graph
OxyFlax Mar 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions src/contributions/PRInfo/PRInfo.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,6 +535,7 @@ class RepositoryServiceHubContent extends React.Component<{}, IRepositoryService
let reviewerPieChartData = getPieChartInfo(this.approverList.value);
let groupBarChartData = getStackedBarChartInfo(this.approvalGroupList,"");
let reviewerBarChartData = getStackedBarChartInfo(this.approverList.value, this.noReviewerText);
let smallNumberOfReviewers = reviewerPieChartData.labels.length < 7
let durationTrenChartData = getDurationBarChartInfo(this.durationSlices);
let closedPRChartData = getPullRequestsCompletedChartInfo(this.durationSlices);
if(doneLoading)
Expand Down Expand Up @@ -722,16 +723,19 @@ class RepositoryServiceHubContent extends React.Component<{}, IRepositoryService
</div>
</Card>
</div>
<div className="flex-column" style={{minWidth:"500px"}}>
<Card className="flex-grow">
<div className="flex-row flex-grow flex-cell" style={{minWidth:"500px",height:"220"}}>
<Doughnut data={reviewerPieChartData} height={220}></Doughnut>
{/* Removing the Doughnut when there are too many reviewers */}
{smallNumberOfReviewers &&
<div className="flex-column" style={{minWidth:"500px"}}>
<Card className="flex-grow">
<div className="flex-row flex-grow flex-cell" style={{minWidth:"500px",height:"220"}}>
<Doughnut data={reviewerPieChartData} height={220}></Doughnut>
</div>
</Card>
</div>
</Card>
</div>
}
<div className="flex-column">
<Card>
<div className="flex-row" style={{minWidth:400, height:"300"}}>
<div className="flex-row" style={{minWidth:smallNumberOfReviewers ? 400 : 800, height:smallNumberOfReviewers ? 400 : 800}}>
<Bar data={reviewerBarChartData} options={stackedChartOptions} height={300}></Bar>
</div>
</Card>
Expand Down