Add mobile select-on-press and pinch zoom/rotate (SP-006)#17
Merged
Conversation
… (SP-006). - Pinch around centroid with live Konva updates; commit items on touchend - createInstanceId fallback for non-secure HTTP; live dimension labels during pinch - Docs app hydration fixes for mobile LAN testing Co-authored-by: Cursor <cursoragent@cursor.com>
- Enhance Konva Group/Stage mocks for pinch gesture integration tests - Wrap dimension label event emits in act(); extend selectedStickerPinch tests Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements StickPak Kanban SP-006: mobile select-on-press and two-finger pinch zoom/rotate on the selected sticker. Bumps
@jeffgo10/react-canvas-designerto 0.2.22 with centroid-pivot pinch geometry, flicker-free live Konva updates, and live dimension labels during gestures. Also fixes docs-app hydration issues when testing/stickpakover LAN on mobile.Changes
Packages (
@jeffgo10/react-canvas-designerv0.2.22)mousedown/touchstartinstead of tap/clickselectedStickerPinch.ts)itemsonce ontouchendSelectionDimensionLabelslistens for custompinchliveevent and reads live node scalecreateInstanceId(): Fallback whencrypto.randomUUIDis unavailable (non-secure HTTP / LAN dev)Docs app (
apps/docs)StickPakCanvasSectionto avoid SSR bailout hydration mismatchessuppressHydrationWarningon root<html>/<body>for extension-injected attributesDocs / Cursor rules
ls-foundry-core.mdcTest utils
Transformermock gainsresizeEnabled/rotateEnabledCommits
c5a444bTest plan
pnpm test --filter=@jeffgo10/react-canvas-designerpnpm run build:packagespnpm run dev --filter=@ls-foundry/docs→/stickpakon desktop (select-on-press, transformer still works)192.168.x.x:3000/stickpak): no hydration errors; add image via Google Drive; pinch zoom/rotate selected sticker; dimension labels track edges during gestureNotes / follow-ups
@jeffgo10/react-canvas-designer@0.2.22in sticker-print-app when ready to ship to storefrontpublish-changed.shMade with Cursor