Migrate from dep to Go modules and update all dependencies#2
Open
jeff-r-skillrev wants to merge 2 commits into
Open
Migrate from dep to Go modules and update all dependencies#2jeff-r-skillrev wants to merge 2 commits into
jeff-r-skillrev wants to merge 2 commits into
Conversation
- Replace Gopkg.toml/Gopkg.lock with go.mod/go.sum (dep is deprecated) - Update github.com/google/uuid: v0.2 → v1.6.0 - Update github.com/gorilla/mux: v1.6.2 → v1.8.1 - Update github.com/gorilla/handlers: v1.4.0 → v1.5.2 - Add github.com/felixge/httpsnoop v1.0.4 (explicit indirect dep of handlers) - Remove github.com/gorilla/context (no longer needed with modern mux) - Fix unbuffered os.Signal channel in main.go (flagged by go vet) Co-Authored-By: claude-flow <ruv@ruv.net>
Following modern Go best practices — go.mod/go.sum provide reproducible builds via the module proxy without committing vendor. Co-Authored-By: claude-flow <ruv@ruv.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dep(Gopkg.toml/Gopkg.lock) with Go modules (go.mod/go.sum)github.com/google/uuid: v0.2 → v1.6.0github.com/gorilla/mux: v1.6.2 → v1.8.1github.com/gorilla/handlers: v1.4.0 → v1.5.2github.com/felixge/httpsnoop: added v1.0.4 (explicit indirect dep of handlers)github.com/gorilla/context(no longer needed with modern mux)os.Signalchannel inmain.go(flagged bygo vet— could cause signal loss on shutdown)Test plan
go build ./...passesgo vet ./...passes cleanlygo test ./...passes (test package passes)🤖 Generated with claude-flow