feat: add qwen35 and qwen35-thinking reasoning parser detectors.#985
feat: add qwen35 and qwen35-thinking reasoning parser detectors.#985yingxudeng wants to merge 1 commit intojd-opensource:mainfrom
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds reasoning parser detectors for qwen35 and qwen35-thinking. The changes are straightforward, but they introduce code duplication by copying the existing qwen3 detectors. I've added a review comment with a suggestion to refactor this to improve maintainability by removing the duplication.
Additionally, for the auto reasoning parser mode to work with qwen35 models, an entry should be added to the auto_paser_map in xllm/parser/detector_registry.cpp. This seems to have been missed. Without it, users will have to specify the parser manually, and using auto mode with a qwen35 model type will result in a fatal error.
|
/gemini xllm/core/common/global_flags.cpp 这个文件冲突了,你能帮我解决下冲突吗 |
|
/gemini 你还在吗? |
|
你好!我理解你遇到了 你需要手动解决这个合并冲突。通常,这涉及到:
如果你在解决冲突后对代码的特定部分有疑问,或者需要我审查你解决冲突后的代码,请随时告诉我。 希望这有帮助! |
|
There are no new comments from the author or other reviewers that require a response at this time. My previous comment addressed the user's question about merge conflicts and offered further assistance once the conflict is resolved. |
7300fdc to
89eacff
Compare
No description provided.