Skip to content

feat: add qwen35 and qwen35-thinking reasoning parser detectors.#985

Open
yingxudeng wants to merge 1 commit intojd-opensource:mainfrom
yingxudeng:feat/qwen35_think
Open

feat: add qwen35 and qwen35-thinking reasoning parser detectors.#985
yingxudeng wants to merge 1 commit intojd-opensource:mainfrom
yingxudeng:feat/qwen35_think

Conversation

@yingxudeng
Copy link
Collaborator

No description provided.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds reasoning parser detectors for qwen35 and qwen35-thinking. The changes are straightforward, but they introduce code duplication by copying the existing qwen3 detectors. I've added a review comment with a suggestion to refactor this to improve maintainability by removing the duplication.

Additionally, for the auto reasoning parser mode to work with qwen35 models, an entry should be added to the auto_paser_map in xllm/parser/detector_registry.cpp. This seems to have been missed. Without it, users will have to specify the parser manually, and using auto mode with a qwen35 model type will result in a fatal error.

yq33victor
yq33victor previously approved these changes Mar 9, 2026
Copy link
Collaborator

@yq33victor yq33victor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yingxudeng
Copy link
Collaborator Author

/gemini xllm/core/common/global_flags.cpp 这个文件冲突了,你能帮我解决下冲突吗

@yingxudeng
Copy link
Collaborator Author

/gemini 你还在吗?

@gemini-code-assist
Copy link
Contributor

你好!我理解你遇到了 xllm/core/common/global_flags.cpp 文件的合并冲突。作为一个AI助手,我无法直接执行操作来解决代码冲突或修改你的仓库。我的职责是提供代码审查的反馈和建议。

你需要手动解决这个合并冲突。通常,这涉及到:

  1. 在你的本地环境中拉取最新的代码。
  2. 使用版本控制工具(如Git)来查看冲突并手动编辑文件,选择你想要保留的更改。
  3. 提交解决冲突后的文件。

如果你在解决冲突后对代码的特定部分有疑问,或者需要我审查你解决冲突后的代码,请随时告诉我。

希望这有帮助!

@gemini-code-assist
Copy link
Contributor

There are no new comments from the author or other reviewers that require a response at this time. My previous comment addressed the user's question about merge conflicts and offered further assistance once the conflict is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants