feat: add onerec model implement[2/N]#981
Merged
DragonFive merged 8 commits intojd-opensource:mainfrom Mar 12, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the wiring for a new onerec_block_layer for NPU, including the abstract base class, NPU implementation, and build system changes. The implementation of NpuOneRecBlockLayerImpl::forward appears to be a placeholder, which is expected for a wiring PR. I've found a critical issue in the tensor device placement logic within the forward method that could lead to runtime errors. Please see the specific comment for details.
XuZhang99
reviewed
Mar 5, 2026
walsonyang
reviewed
Mar 6, 2026
daf845a to
1bf8ce2
Compare
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
1bf8ce2 to
8e12383
Compare
RobbieLeung
reviewed
Mar 10, 2026
RobbieLeung
reviewed
Mar 10, 2026
walsonyang
reviewed
Mar 11, 2026
walsonyang
approved these changes
Mar 11, 2026
LMX-xin
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR is the second step of the OneRec rebaseline stack, following #970
It focuses on NPU block-layer wiring and OneRec runtime input/plumbing hardening on top of current main, while keeping existing non-
OneRec model paths stable.
What's included
Scope / Restrictions
Backward Compatibility
Testing