refactor: replace NULL with nullptr.#1061
Merged
XuZhang99 merged 2 commits intojd-opensource:mainfrom Mar 17, 2026
Merged
Conversation
Dragonliu2018
requested review from
DongheJin,
JimHsiung,
RobbieLeung,
XuZhang99,
liutongxuan,
walsonyang and
yq33victor
as code owners
Dragonliu2018
changed the title
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request correctly replaces NULL and 0 with nullptr for better type safety in C++. While reviewing these changes, I discovered a critical bug in the ClosureGuard's default constructor. It fails to initialize all member function objects, which can lead to a crash at runtime. My review includes a specific comment with a suggested fix for this issue.
Dragonliu2018
force-pushed
the
lzl/refactor/prefer_nullptr
branch
from
23780bb to
ae39f4e
Compare
XuZhang99
reviewed
Mar 15, 2026
RobbieLeung
previously approved these changes
Mar 16, 2026
XuZhang99
approved these changes
Mar 16, 2026
RobbieLeung
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace NULL with nullptr following "Effective Modern C++" Item 8 guidelines.