feat: add unified request stats logs for prefill and service.#1038
Open
DongheJin wants to merge 1 commit intojd-opensource:mainfrom
Open
feat: add unified request stats logs for prefill and service.#1038DongheJin wants to merge 1 commit intojd-opensource:mainfrom
DongheJin wants to merge 1 commit intojd-opensource:mainfrom
Conversation
DongheJin
requested review from
JimHsiung,
RobbieLeung,
XuZhang99,
liutongxuan,
walsonyang and
yq33victor
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds unified request stats logs by propagating x_request_id and x_request_time through the system. The changes are generally good, but I've identified an instance of redundant data being passed between services. The x_request_id and x_request_time are passed when the first token is generated, but this information is already available on the receiving service. Removing this redundancy would simplify the code and reduce data transfer. Please see my specific comment.
walsonyang
reviewed
Mar 12, 2026
DongheJin
force-pushed
the
feat/pd
branch
2 times, most recently
from
8dc724a to
4508cf1
Compare
JimHsiung
approved these changes
Mar 12, 2026
weizhehuang0827
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.