refactor: remove the outdated glm5 model type.#1034
Merged
XuZhang99 merged 1 commit intojd-opensource:mainfrom Mar 12, 2026
Merged
refactor: remove the outdated glm5 model type.#1034XuZhang99 merged 1 commit intojd-opensource:mainfrom
XuZhang99 merged 1 commit intojd-opensource:mainfrom
Conversation
yq33victor
requested review from
DongheJin,
JimHsiung,
RobbieLeung,
XuZhang99,
liutongxuan and
walsonyang
as code owners
XuZhang99
reviewed
Mar 11, 2026
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the codebase to remove the outdated glm5_moe model type and consolidates its functionality into glm_moe_dsa. The changes are consistent across multiple files, including updating model registration, argument loading, and logic that depends on the model type. My review focuses on the maintainability of the code after this refactoring.
Signed-off-by: yq33victor <pengtao.156@jd.com>
yq33victor
force-pushed
the
dev/fix_glm5
branch
from
968b0d5 to
2d78c4f
Compare
XuZhang99
approved these changes
Mar 11, 2026
RobbieLeung
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.