Skip to content

github: only build on PR approval, skip on raw push/open.#1012

Open
Clement-Wang26 wants to merge 1 commit intojd-opensource:mainfrom
Clement-Wang26:fixpr
Open

github: only build on PR approval, skip on raw push/open.#1012
Clement-Wang26 wants to merge 1 commit intojd-opensource:mainfrom
Clement-Wang26:fixpr

Conversation

@Clement-Wang26
Copy link
Collaborator

@Clement-Wang26 Clement-Wang26 commented Mar 6, 2026

Event Conflict check Sensitive file check Format check Build
workflow_dispatch — — — ✅ Always
push to main — ✅ Fail if hit — ❌ Never
pull_request ✅ Silent skip ✅ Fail if hit ✅ Always ❌ Never
pull_request_review ✅ Silent skip ✅ Silent skip — ✅ First approval
issue_comment /build ✅ Silent skip ✅ Silent skip ✅ Yes ✅ Yes

Legend:

  • Silent skip = exits with ✅, no build
  • Fail = exits with ❌, blocks merge"

@XuZhang99 XuZhang99 changed the title feat: only build on PR approval, skip on raw push/open. github: only build on PR approval, skip on raw push/open. Mar 6, 2026
XuZhang99
XuZhang99 previously approved these changes Mar 6, 2026
View reviewed changes
@Clement-Wang26
Copy link
Collaborator Author

Clement-Wang26 commented Mar 10, 2026

/build

XuZhang99
XuZhang99 previously approved these changes Mar 10, 2026
View reviewed changes
@Clement-Wang26
Copy link
Collaborator Author

Clement-Wang26 commented Mar 14, 2026

/build

Clement-Wang26
Clement-Wang26 commented Mar 14, 2026
View reviewed changes
xllm/core/layers/npu/loader/base_manual_loader.cpp
}

void BaseManualLoader::init_weight_slices() {
int wy = 0;
Copy link
Collaborator Author

@Clement-Wang26 Clement-Wang26 Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/build

@Clement-Wang26
Copy link
Collaborator Author

Clement-Wang26 commented Mar 14, 2026

/build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XuZhang99 XuZhang99 XuZhang99 approved these changes

@yq33victor yq33victor Awaiting requested review from yq33victor yq33victor is a code owner

@liutongxuan liutongxuan Awaiting requested review from liutongxuan liutongxuan is a code owner

@walsonyang walsonyang Awaiting requested review from walsonyang walsonyang is a code owner

@RobbieLeung RobbieLeung Awaiting requested review from RobbieLeung RobbieLeung is a code owner

@JimHsiung JimHsiung Awaiting requested review from JimHsiung JimHsiung is a code owner

@DongheJin DongheJin Awaiting requested review from DongheJin DongheJin is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Clement-Wang26 @XuZhang99