Fix pointer_hash to use unsigned type for logical shift#24
Merged
jcmosc merged 1 commit intojcmosc:mainfrom Feb 25, 2026
Merged
Fix pointer_hash to use unsigned type for logical shift#24jcmosc merged 1 commit intojcmosc:mainfrom
jcmosc merged 1 commit intojcmosc:mainfrom
Conversation
Use uint64_t instead of int64_t in pointer_hash so that left shift operations compile to lsl (logical shift left) instead of asl (arithmetic shift left).
Kyle-Ye
force-pushed
the
fix/pointer-hash-unsigned-shift
branch
from
5ee9b77 to
3cb5f76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use uint64_t instead of int64_t in pointer_hash so that left shift
operations compile to lsl (logical shift left) instead of asl
(arithmetic shift left).