Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7988e4979f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| text = "QXCFGMSG,1,6,0" | ||
| tag = "nmea-off" |
There was a problem hiding this comment.
When a user enables GST with -t nmea-gst and later runs -t nmea-off, GST remains enabled because this nmea-off group disables message IDs 0 through 6 only, while the file maps GST to ID 7 and provides a dedicated nmea-gst-off command above. That leaves extra NMEA traffic on the serial line even though the tag description says all NMEA messages are disabled; add QXCFGMSG,1,7,0 to this group.
Useful? React with 👍 / 👎.
configs/gpsmsg/qianxun/mc280.toml: configuration messages for the Qianxun MC280/MC282 receiver (QX "Buguang" ASCII protocol). Tags for version query, NMEA output control, fix rate, NMEA version, elevation mask, GNSS constellation and L1 / L1+L5 band selection, PPS (GPS time reference), base mode (fixed position and survey-in), RTCM output, save/reload/reset, and serial speed. Tags carry verification notes from testing against a real MC280, recording what the firmware accepts and what it does not (e.g. the QXMONVER version query and standard RTCM MSM output).
QXCFGMSG class-1 GST is message ID 7, which the nmea-off group omitted, so GST stayed enabled after nmea-off despite the "disable all" description. Add QXCFGMSG,1,7,0 to the group (addresses PR review).
1 participant
Adds
configs/gpsmsg/qianxun/mc280.toml, a satpulsetool message file for theQianxun MC280/MC282 receiver (QX "Buguang" ASCII protocol, spec V1.74).
Tags cover: version query, NMEA output control (per-sentence +
nmea-daemon),fix rate, NMEA version, elevation mask, GNSS constellation, L1 / L1+L5 band
selection, PPS (GPS time reference), base mode (fixed position + survey-in),
RTCM output, save/reload/reset, and serial speed.
Tested against a real MC280 over a remote serial link; each tag carries
verification notes recording what the firmware accepts and what it does not.
Works (verified on the wire): all
get-*queries except version; NMEAoutput control;
fix-rate-*;nmea-ver-410;min-elev-*;gnss-*;band-l1/band-l1-l5;pps/pps-off;fixed-pos-exampleandsurvey(base mode);
reload.Not supported on this firmware (documented in the file):
QXMONVERversion query returns$NACK(no documented alternative).proprietary RTCM 4068 instead; per-type RTCM control is a single global slot.
Inconclusive: RTCM observation content — the test unit never achieved a fix
(antenna reported open), so whether 4068/MSM carries real observations is untested.
save/factory-reset/reset/speed-*are present but were not exercised(persistent or link-breaking on the remote unit).