Add paginationComponentOptions.minWindowWidth (defaults to SMALL == 599)#1227
Open
ryan-williams wants to merge 1 commit intojbetancur:masterfrom
Open
Add paginationComponentOptions.minWindowWidth (defaults to SMALL == 599)#1227ryan-williams wants to merge 1 commit intojbetancur:masterfrom
paginationComponentOptions.minWindowWidth (defaults to SMALL == 599)#1227ryan-williams wants to merge 1 commit intojbetancur:masterfrom
Conversation
✅ Deploy Preview for react-data-table-component ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ryan-williams
changed the title
paginationComponentOptions.minWindowSize (defaults to SMALL == 599)paginationComponentOptions.minWindowWidth (defaults to SMALL == 599)
Author
|
Just noticed #1103, I think this addresses that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conditional rendering in
Paginationcauses SSR hydration errors in Next.js appswindow.innerWidth ≥ 599).Workaround / Fix
This PR adds the ability to pass
paginationComponentOptions={{ minWindowWidth: null }}toDataTable, to always render the "rows per page" and "page range" parts of the pagination footer, which ensures server and client DOMs will match.