ListField: removed default None value for the items_types parameter.#97
Open
avrahamshukron wants to merge 3 commits intojazzband:masterfrom
Open
ListField: removed default None value for the items_types parameter.#97avrahamshukron wants to merge 3 commits intojazzband:masterfrom
None value for the items_types parameter.#97avrahamshukron wants to merge 3 commits intojazzband:masterfrom
Conversation
This will create more consistent code since `item_types` _is_ required. Tests had to be modified a bit. Specifically tests which used Model class with circular reference to itself. It was easier to just extract the dummy class outside the function, in order to avoid import path hell. This change breaks the current API, so if merged it should be into a new major version.
avrahamshukron
changed the title
None value for the items_type parameter.None value for the items_types parameter.
Collaborator
|
@avrahamshukron nice, and you are right - therefore lets make version 3 :) before that I need to release some small improvements to branch 2.x and then we will do all BC breaking stuff (this and regexes too) |
Contributor
Author
|
Sure, thanks! |
Collaborator
|
Ok, no problem |
Contributor
Author
|
I totally forgot about this... If it is still relevant you can absolutely merge this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will create more consistent code since
item_typesis required.Tests had to be modified a bit. Specifically tests which used Model
class with circular reference to itself. It was easier to just extract
the dummy class outside the function, in order to avoid import path hell.
This change breaks the current API, so if merged it should be into a new
major version.
Fixes #96