add is_valid logic to base model#173
Open
mojtabaakbari221b wants to merge 2 commits intojazzband:masterfrom
Open
add is_valid logic to base model#173mojtabaakbari221b wants to merge 2 commits intojazzband:masterfrom
mojtabaakbari221b wants to merge 2 commits intojazzband:masterfrom
Conversation
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suppose you want to validate a schema, in the current state, you should call the validate function and see if it is none, that means the data is valid.
The first problem is that we don't have a clean code of true or false, and the second is that we don't have a list of fields that are invalid, and we only know about 1 field being invalid.
The second problem: suppose we want to return a list of invalid fields to the user, how?
This is how you can do these things with the new codes :
And imagine that we use drf in our api development.
In general, this implementation is inspired by the implementation of isـvalid in drf serializer