Run build on PRs; keep deploy gated to push:main#12
Merged
Conversation
Closes #8. PRs now get a build status check; deploy job and Pages artifact upload are gated to push events on main so PRs never deploy. Concurrency moved from workflow level to the deploy job so PR builds don't share the `pages` group with in-flight deploys. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pull_requestto the deploy workflow's triggers so every PR runsnpm ci && npm run buildand surfaces a status check.deployjob and theUpload Pages artifactstep ongithub.event_name == 'push' && github.ref == 'refs/heads/main'— PRs never deploy and never upload a Pages artifact.concurrency: group: pagesfrom the workflow level down to thedeployjob. Otherwise, a PR build kicked off mid-deploy would share thepagesgroup and cancel the in-flight production deploy.Test plan
deployjob is skipped on this PR (visible in the Checks tab).mainstill deploys end-to-end.🤖 Generated with Claude Code