Create src/runs/pr-checks.ts and move the PR-merge/URL-parse group into…#391
Open
jayminwest wants to merge 2 commits into
Open
Create src/runs/pr-checks.ts and move the PR-merge/URL-parse group into…#391jayminwest wants to merge 2 commits into
jayminwest wants to merge 2 commits into
Conversation
Move checkPullRequestMerged, mergePullRequest, parsePullRequestUrl, parsePullRequestRef, isRateLimited and their exported types/regexes out of src/runs/pr.ts into a new src/runs/pr-checks.ts. Shared GitHub REST helpers (buildHeaders/readJson/readText/truncate/readGhFetchOverride/ GITHUB_API_BASE/GH_FETCH_OVERRIDE_ENV) live in pr-checks.ts and are imported by pr.ts (one copy, no duplication). pr.ts re-exports every moved public symbol so the ../runs/pr.ts import path still resolves. pr.ts drops from 659 to 361 lines. mergePullRequest's grandfathered complexity override follows it to pr-checks.ts in biome.json. Refs: warren-db9a (pl-88bb step 1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
refactor(runs): split PR-merge/URL-parse group into pr-checks.ts
Run
run_etn8ndfywq3kSeeds
wc -l src/runs/pr.tsshows < 500 ANDbun run typecheckis clean ANDbun test src/runs/pr.test.tsis green with the same test count as before the split.Commits (2)
Files changed
Prompt
Show prompt
🤖 Opened by warren run
run_etn8ndfywq3k