Skip to content

quality: adopt canonical check:all standard (pl-cf2a)#338

Merged
jayminwest merged 5 commits into
mainfrom
check-all-standard
Jun 13, 2026
Merged

quality: adopt canonical check:all standard (pl-cf2a)#338
jayminwest merged 5 commits into
mainfrom
check-all-standard

Conversation

@jayminwest

Copy link
Copy Markdown
Owner

Conforms warren to the os-eco fleet check:all standard (docs/check-all-standard.md at the os-eco root, frozen rev 1). Implements seeds plan pl-cf2a (children warren-c123, warren-0628, warren-3a0f).

What changed

1. Canonical gate vocabulary (warren-c123)

Renamed the verbose package.json gate keys to the frozen terse names — no deprecated aliases kept:

Old New
check:file-sizes check:size
check:debt-markers check:debt
check:duplicates check:dups
validate:agents-md check:agents

All references updated: .github/workflows/ci.yml, CLAUDE.md, AGENTS.md, src/server/__golden__/responses/README.md, scripts/validate-agents-md.test.ts fixture. (ci-postgres.yml invokes only bun test — nothing to rename. CHANGELOG history left as-is.)

2. Canonical quiet runner (warren-0628)

  • scripts/check-all.ts + scripts/check-all.test.ts copied byte-identical from templates/l5-toolkit/scripts/.
  • "check:all": "bun scripts/check-all.ts", new "verify": "bun run check:all".
  • Resolved manifest (12 gates): lint, typecheck, check:agents, check:dups, check:deps, check:size, check:debt, check:bundle-size, gen:docs:check, gen:openapi:check, check:coverage, check:ci-parity.
  • check:bundle-size now points at the self-contained --build variant (frozen-lockfile UI install + build + measure); the separate check:bundle-size:build script is removed. CI's existing bun run check:bundle-size step keeps working under the canonical name — no alias needed.

3. Fleet-canonical CI-parity gate (warren-3a0f)

  • scripts/check-ci-parity.ts + test replaced with the byte-identical template copies (imports GATES from check-all.ts, parses every .github/workflows/ci*.yml — covers both ci.yml and ci-postgres.yml).
  • Warren's escape hatches moved out of the script into scripts/ci-parity-config.json with per-entry justification: aliases: { "check:coverage:ci": "check:coverage" }; ciOnly: ["ui:install", "build:ui", "report:test-timing", "report:quality-metrics"] (verified against what ci.yml actually invokes).
  • yaml added as a devDependency (template's workflow parser); js-yaml + @types/js-yaml stay — still used across src/ (warren-config, CLI, OpenAPI generator); knip is green.
  • CLAUDE.md Quality Gates section rewritten: runner, quiet-output contract, verify alias, ci-parity config.

Note: Biome formatter exemption

The frozen template scripts don't satisfy Biome's formatter at lineWidth 100 (they fail even the l5-toolkit's own biome baseline), so biome.json gains an override disabling the formatter (linter still applies) for exactly scripts/check-all.ts and scripts/check-ci-parity.ts — local formatting can never break byte-identity.

Acceptance verification

  • bun run check:all and bun run verify: 12/12 gates passed (27.6s), quiet contract observed (one aligned line per gate, one-line tally).
  • cmp against templates/l5-toolkit/scripts/ shows no differences for check-all.ts, check-all.test.ts, check-ci-parity.ts, check-ci-parity.test.ts.
  • check:ci-parity: 13 bun-run invocations across CI workflows, all reachable from check:all.
  • The repo's own pre-commit hook (exec bun run check:all) ran the new runner green at commit time.

🤖 Generated with Claude Code

jayminwest and others added 3 commits June 11, 2026 22:46
Conform warren to the os-eco fleet check:all standard
(docs/check-all-standard.md at the os-eco root):

- Rename verbose gate keys to the frozen terse vocabulary:
  check:file-sizes -> check:size, check:debt-markers -> check:debt,
  check:duplicates -> check:dups, validate:agents-md -> check:agents
  (no deprecated aliases kept); update CI workflow + doc references.
- Replace the 12-gate && chain with the byte-identical quiet runner
  scripts/check-all.ts (copied from templates/l5-toolkit/scripts) and
  add the "verify" alias. Resolved manifest: lint, typecheck,
  check:agents, check:dups, check:deps, check:size, check:debt,
  check:bundle-size, gen:docs:check, gen:openapi:check,
  check:coverage, check:ci-parity.
- check:bundle-size now carries --build (self-contained
  frozen-lockfile UI build); check:bundle-size:build removed.
- Replace scripts/check-ci-parity.ts (+ test) with the fleet-canonical
  template copy that imports GATES from check-all.ts and uses the yaml
  package; warren's escape hatches move to scripts/ci-parity-config.json
  (aliases: check:coverage:ci; ciOnly: ui:install, build:ui,
  report:test-timing, report:quality-metrics).
- Exempt the two frozen scripts from Biome's formatter via a
  biome.json override (linter still applies) so local formatting can
  never break byte-identity with the template.

Verified: bun run check:all and bun run verify both green —
12/12 gates passed; cmp confirms byte-identity for check-all.ts,
check-ci-parity.ts, and both test files.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
jayminwest and others added 2 commits June 13, 2026 10:49
Fable 5 is being retired, so the weekly Sunday taste-digest patrol
(tastewatch-digest cron '0 4 * * 0') can no longer dispatch on it.
Repin tastewatch to claude-opus-4-8, the strongest model still
available — consistent with the agent's "strongest available model"
mandate. Updated via `cn update --fm` (canopy v2) + `cn emit`.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@jayminwest jayminwest merged commit 5f41fef into main Jun 13, 2026
2 of 3 checks passed
@jayminwest jayminwest deleted the check-all-standard branch June 13, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant