quality: adopt canonical check:all standard (pl-cf2a)#338
Merged
Conversation
Conform warren to the os-eco fleet check:all standard (docs/check-all-standard.md at the os-eco root): - Rename verbose gate keys to the frozen terse vocabulary: check:file-sizes -> check:size, check:debt-markers -> check:debt, check:duplicates -> check:dups, validate:agents-md -> check:agents (no deprecated aliases kept); update CI workflow + doc references. - Replace the 12-gate && chain with the byte-identical quiet runner scripts/check-all.ts (copied from templates/l5-toolkit/scripts) and add the "verify" alias. Resolved manifest: lint, typecheck, check:agents, check:dups, check:deps, check:size, check:debt, check:bundle-size, gen:docs:check, gen:openapi:check, check:coverage, check:ci-parity. - check:bundle-size now carries --build (self-contained frozen-lockfile UI build); check:bundle-size:build removed. - Replace scripts/check-ci-parity.ts (+ test) with the fleet-canonical template copy that imports GATES from check-all.ts and uses the yaml package; warren's escape hatches move to scripts/ci-parity-config.json (aliases: check:coverage:ci; ciOnly: ui:install, build:ui, report:test-timing, report:quality-metrics). - Exempt the two frozen scripts from Biome's formatter via a biome.json override (linter still applies) so local formatting can never break byte-identity with the template. Verified: bun run check:all and bun run verify both green — 12/12 gates passed; cmp confirms byte-identity for check-all.ts, check-ci-parity.ts, and both test files. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Fable 5 is being retired, so the weekly Sunday taste-digest patrol (tastewatch-digest cron '0 4 * * 0') can no longer dispatch on it. Repin tastewatch to claude-opus-4-8, the strongest model still available — consistent with the agent's "strongest available model" mandate. Updated via `cn update --fm` (canopy v2) + `cn emit`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Conforms warren to the os-eco fleet
check:allstandard (docs/check-all-standard.mdat the os-eco root, frozen rev 1). Implements seeds plan pl-cf2a (children warren-c123, warren-0628, warren-3a0f).What changed
1. Canonical gate vocabulary (warren-c123)
Renamed the verbose package.json gate keys to the frozen terse names — no deprecated aliases kept:
check:file-sizescheck:sizecheck:debt-markerscheck:debtcheck:duplicatescheck:dupsvalidate:agents-mdcheck:agentsAll references updated:
.github/workflows/ci.yml,CLAUDE.md,AGENTS.md,src/server/__golden__/responses/README.md,scripts/validate-agents-md.test.tsfixture. (ci-postgres.ymlinvokes onlybun test— nothing to rename. CHANGELOG history left as-is.)2. Canonical quiet runner (warren-0628)
scripts/check-all.ts+scripts/check-all.test.tscopied byte-identical fromtemplates/l5-toolkit/scripts/."check:all": "bun scripts/check-all.ts", new"verify": "bun run check:all".lint,typecheck,check:agents,check:dups,check:deps,check:size,check:debt,check:bundle-size,gen:docs:check,gen:openapi:check,check:coverage,check:ci-parity.check:bundle-sizenow points at the self-contained--buildvariant (frozen-lockfile UI install + build + measure); the separatecheck:bundle-size:buildscript is removed. CI's existingbun run check:bundle-sizestep keeps working under the canonical name — no alias needed.3. Fleet-canonical CI-parity gate (warren-3a0f)
scripts/check-ci-parity.ts+ test replaced with the byte-identical template copies (importsGATESfromcheck-all.ts, parses every.github/workflows/ci*.yml— covers bothci.ymlandci-postgres.yml).scripts/ci-parity-config.jsonwith per-entry justification:aliases: { "check:coverage:ci": "check:coverage" };ciOnly: ["ui:install", "build:ui", "report:test-timing", "report:quality-metrics"](verified against what ci.yml actually invokes).yamladded as a devDependency (template's workflow parser);js-yaml+@types/js-yamlstay — still used acrosssrc/(warren-config, CLI, OpenAPI generator); knip is green.CLAUDE.mdQuality Gates section rewritten: runner, quiet-output contract,verifyalias, ci-parity config.Note: Biome formatter exemption
The frozen template scripts don't satisfy Biome's formatter at lineWidth 100 (they fail even the l5-toolkit's own biome baseline), so
biome.jsongains an override disabling the formatter (linter still applies) for exactlyscripts/check-all.tsandscripts/check-ci-parity.ts— local formatting can never break byte-identity.Acceptance verification
bun run check:allandbun run verify: 12/12 gates passed (27.6s), quiet contract observed (one aligned line per gate, one-line tally).cmpagainsttemplates/l5-toolkit/scripts/shows no differences forcheck-all.ts,check-all.test.ts,check-ci-parity.ts,check-ci-parity.test.ts.check:ci-parity: 13 bun-run invocations across CI workflows, all reachable fromcheck:all.exec bun run check:all) ran the new runner green at commit time.🤖 Generated with Claude Code