Fix path-segment boundary in src/utils/git.ts fileMatchesAny + add fals…#57
Open
jayminwest wants to merge 2 commits into
Open
Fix path-segment boundary in src/utils/git.ts fileMatchesAny + add fals…#57jayminwest wants to merge 2 commits into
jayminwest wants to merge 2 commits into
Conversation
fileMatchesAny previously used raw String.endsWith, so 'cli.ts' falsely matched 'src/other-cli.ts'. Require the longer side to have a '/' immediately before the suffix so matches align on path segments. Equal strings still match. Add false-positive coverage in test/commands/prime.test.ts asserting 'cli.ts' vs 'src/other-cli.ts' and 'prime.ts' vs 'src/commands/reprime.ts' both return false, while boundary-aligned suffixes still match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mulch: fix path-segment boundary in fileMatchesAny (sd mulch-9465)
Run
run_r8kk4nzyt55kSeeds
Commits (2)
Files changed
Prompt
Show prompt
🤖 Opened by warren run
run_r8kk4nzyt55k