Skip to content

olmo3#134

Open
chapman20j wants to merge 4 commits intojax-ml:mainfrom
chapman20j:olmo3
Open

olmo3#134
chapman20j wants to merge 4 commits intojax-ml:mainfrom
chapman20j:olmo3

Conversation

@chapman20j
Copy link
Copy Markdown
Collaborator

Resolves #126

Checklist

  • I have read the Contribution Guidelines and used pre-commit hooks to format this commit.
  • I have added all the necessary unit tests for my change. (run_model.py for model usage, test_outputs.py and/or model_validation_colab.ipynb for quality).
  • (If using an LLM) I have carefully reviewed and removed all superfluous comments or unneeded, commented-out code. Only necessary and functional code remains.
  • I have signed the Contributor License Agreement (CLA).

Comment thread bonsai/models/olmo3/README.md Outdated
@jenriver
Copy link
Copy Markdown
Member

Could you relax the tolerance to 1e-5 and ensure the numeric tests do pass on CI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Olmo3

3 participants