Enhance router initialization logging#98
Merged
Merged
Conversation
…mplateServerRouter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request focuses on improving the testability and reliability of the
TemplateServerby refactoring test fixtures and enhancing dependency injection for the router and limiter components. The changes ensure that tests use mock instances for dependencies, making tests more isolated and maintainable.Test infrastructure improvements:
mock_template_server_routerfixture intests/conftest.pyto accept a mockLimiterinstance, and introduced a newmock_limiterfixture to provide this mock, allowing for more flexible and isolated testing of rate limiting logic.mock_template_serverfixture intests/test_template_server.pyto patchTemplateServerRouterwith the mock router fixture, ensuring that tests use the mock router instead of the real implementation.test_initmethod inTestTemplateServerto verify that all routes from the mock router are included in the FastAPI app, improving the accuracy of route registration tests.TemplateServerRouterintests/test_template_server.pyto support the updated fixtures and tests.Minor logging improvement:
BaseRouterto display'/'when the prefix is empty orNone, improving log clarity.