Update db init#91
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the structure and documentation of the database manager module in the server template. The changes clarify how to import and subclass the
BaseDatabaseManager, and update its usage in tests.Module structure and imports:
BaseDatabaseManagerinpython_template_server/db/__init__.pyand updated__all__to make it available for direct import from thedbpackage.from python_template_server.db import BaseDatabaseManagerinstead of importing directly from the module.Documentation and code clarity:
BaseDatabaseManagerto clarify that subclasses must implement thedb_urlproperty.db_urlproperty to specify that it should use theDatabaseConfig.db_url()method.