Skip to content

Update db init#91

Merged
javidahmed64592 merged 2 commits into
mainfrom
update-db-init
May 5, 2026
Merged

Update db init#91
javidahmed64592 merged 2 commits into
mainfrom
update-db-init

Conversation

@javidahmed64592
Copy link
Copy Markdown
Owner

This pull request improves the structure and documentation of the database manager module in the server template. The changes clarify how to import and subclass the BaseDatabaseManager, and update its usage in tests.

Module structure and imports:

  • Added an import for BaseDatabaseManager in python_template_server/db/__init__.py and updated __all__ to make it available for direct import from the db package.
  • Updated the import in the test file to use from python_template_server.db import BaseDatabaseManager instead of importing directly from the module.

Documentation and code clarity:

  • Improved the class docstring for BaseDatabaseManager to clarify that subclasses must implement the db_url property.
  • Updated the docstring for the db_url property to specify that it should use the DatabaseConfig.db_url() method.

@javidahmed64592 javidahmed64592 merged commit e9b7fa3 into main May 5, 2026
16 checks passed
@javidahmed64592 javidahmed64592 deleted the update-db-init branch May 5, 2026 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant