Skip to content

Remove database configuration from TemplateServerConfig #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
javidahmed64592 merged 1 commit into from
May 5, 2026
Merged

Remove database configuration from TemplateServerConfig #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion python_template_server/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ class TemplateServerConfig(BaseModel):
rate_limit: RateLimitConfigModel = Field(default_factory=RateLimitConfigModel)
certificate: CertificateConfigModel = Field(default_factory=CertificateConfigModel)
json_response: JSONResponseConfigModel = Field(default_factory=JSONResponseConfigModel)
db: DatabaseConfig = Field(default_factory=DatabaseConfig, description="Database configuration")

def save_to_file(self, filepath: Path) -> None:
"""Save the configuration to a JSON file.
Expand Down
2 changes: 0 additions & 2 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,6 @@ def mock_template_server_config(
mock_rate_limit_config: RateLimitConfigModel,
mock_certificate_config: CertificateConfigModel,
mock_json_response_config: JSONResponseConfigModel,
mock_db_config: DatabaseConfig,
) -> TemplateServerConfig:
"""Provide a mock TemplateServerConfig instance."""
return TemplateServerConfig(
Expand All @@ -187,5 +186,4 @@ def mock_template_server_config(
rate_limit=mock_rate_limit_config,
certificate=mock_certificate_config,
json_response=mock_json_response_config,
db=mock_db_config,
)
2 changes: 0 additions & 2 deletions tests/test_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@ def test_model_dump(
mock_rate_limit_config_dict: dict,
mock_certificate_config_dict: dict,
mock_json_response_config_dict: dict,
mock_db_config_dict: dict,
) -> None:
"""Test the model_dump method."""
expected_dict = {
Expand All @@ -118,7 +117,6 @@ def test_model_dump(
"rate_limit": mock_rate_limit_config_dict,
"certificate": mock_certificate_config_dict,
"json_response": mock_json_response_config_dict,
"db": mock_db_config_dict,
}
assert mock_template_server_config.model_dump() == expected_dict

Expand Down