Skip to content

Scg fixes#485

Open
juliuspfadt wants to merge 7 commits into
jasp-stats:masterfrom
juliuspfadt:scgFixes
Open

Scg fixes#485
juliuspfadt wants to merge 7 commits into
jasp-stats:masterfrom
juliuspfadt:scgFixes

Conversation

@juliuspfadt

@juliuspfadt juliuspfadt commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

adds z.bench as extra output and also pooled SD for process capability
fixes https://github.com/jasp-stats/INTERNAL-jasp/issues/3260 by changing the way the density line is drawn. this updates all test plots (annoyingly)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of files (300). Try reducing the number of changed files and requesting a review from Copilot again.

@juliuspfadt juliuspfadt requested a review from JTPetter July 2, 2026 09:28
@JTPetter

JTPetter commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Code looks good. But:

  1. All the unit tests fail, also the one with the latest packages. I'd rather have at least one version of them work.
  2. We decided not to mention other statistical software packages anywhere, they are legal trademarks. Please remove all mentions in the comments and help files.
  3. I will verify the output with other software and post below.

@JTPetter JTPetter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

@JTPetter

JTPetter commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

I can confirm the results of both the pooled std. dev. and Z bench on a brief check.

juliuspfadt and others added 3 commits July 3, 2026 16:13
Strip references to other stats software from comments, QML info, and help text (legal trademarks). Leaves functional Rspc convention string values untouched.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
These snapshots skip_on_os("mac"), so baselines were never generated on the
dev machine; Linux/Windows CI hard-failed on the absent baseline. Generated
locally (visual .svg + structural .rds); non-mac CI matches via tolerance/
structural fallback.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@juliuspfadt juliuspfadt requested a review from JTPetter July 3, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants