Skip to content

Minor issues#475

Open
JTPetter wants to merge 3 commits into
jasp-stats:masterfrom
JTPetter:minorIssues
Open

Minor issues#475
JTPetter wants to merge 3 commits into
jasp-stats:masterfrom
JTPetter:minorIssues

Conversation

@JTPetter

@JTPetter JTPetter commented May 19, 2026

Copy link
Copy Markdown
Contributor

This PR fixes a bunch of minor issues:

@github-actions

github-actions Bot commented May 19, 2026

Copy link
Copy Markdown
Contributor

👋 Friendly reminder: It looks like NEWS.md wasn't updated in this Pull Request.

If your changes include bug fixes, new features, or UI tweaks, please consider adding a quick note to the # jaspYourModule (development version) section so our users know about your awesome work! (If this is just a minor typo fix, feel free to ignore this message.)

@JTPetter JTPetter force-pushed the minorIssues branch 2 times, most recently from 81d912d to f5d46ea Compare May 29, 2026 14:29
@codecov-commenter

codecov-commenter commented May 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.60606% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.88%. Comparing base (8c33634) to head (d9d2f81).

Files with missing lines Patch % Lines
R/doeAnalysis.R 30.00% 7 Missing ⚠️
R/msaGaugeRRnonrep.R 14.28% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #475      +/-   ##
==========================================
- Coverage   84.96%   84.88%   -0.08%     
==========================================
  Files          18       18              
  Lines       10012    10032      +20     
==========================================
+ Hits         8507     8516       +9     
- Misses       1505     1516      +11

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JTPetter JTPetter requested review from Copilot and juliuspfadt June 5, 2026 13:55
Copilot AI reviewed Jun 5, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@juliuspfadt juliuspfadt requested a review from Copilot June 5, 2026 14:00
Copilot AI reviewed Jun 5, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 30 changed files in this pull request and generated 2 comments.

Comment thread R/msaTestRetest.R Outdated
Comment thread R/doeAnalysis.R
@juliuspfadt

juliuspfadt commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

can you look into the copilot feedback @JTPetter?

@juliuspfadt

juliuspfadt commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

build builder bot build for glory

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

✅ Build Complete!

Your JASP module bundles have been successfully built for macOS (ARM) and Windows.

👉 Click here to download the artifacts

(Scroll to the bottom of the page to find the "Artifacts" section).

juliuspfadt
juliuspfadt requested changes Jul 1, 2026
View reviewed changes

@juliuspfadt juliuspfadt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you address the copilot feedback, then we can merge it

JTPetter and others added 2 commits July 3, 2026 17:06
@JTPetter
Remove double dependencies
431f5df 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@JTPetter
Improve error message
7a4468c
@JTPetter

JTPetter commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

thanks, done!

@JTPetter JTPetter requested a review from juliuspfadt July 3, 2026 15:22
@juliuspfadt juliuspfadt requested a review from Copilot July 3, 2026 17:08
Copilot AI reviewed Jul 3, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 20 out of 30 changed files in this pull request and generated 4 comments.

Comment thread R/msaGaugeRR.R
Comment on lines +934 to 937
ggplot2::theme(legend.position = "right", legend.title = ggplot2::element_blank(),
plot.margin = ggplot2::margin(5.5, 30, 5.5, 5.5, "pt")) +
ggplot2::xlab(NULL) +
ggplot2::scale_y_continuous(name = "Percent", breaks = yBreaks, limits = range(c(yBreaks, plotframe$value)))
Comment thread R/doeAnalysis.R
Comment on lines +1920 to +1922
termLabels <- attr(stats::terms(result[["object"]]), "term.labels")
missingVars <- variablePair[!sapply(variablePair, function(var) any(grepl(var, termLabels, fixed = TRUE)))]
if (length(missingVars) > 0) {
Comment thread R/msaGaugeRR.R
Comment on lines 252 to 255
if (is.null(jaspResults[["gaugeANOVA"]])) {
jaspResults[["gaugeANOVA"]] <- createJaspContainer(gettext("Gauge r&R ANOVA table"))
jaspResults[["gaugeANOVA"]] <- createJaspContainer(gettext("Gauge r&R Analysis of Variance table"))
jaspResults[["gaugeANOVA"]]$dependOn(c("processVariationReference", "historicalSdValue", "report"))
jaspResults[["gaugeANOVA"]]$position <- 1
Comment thread R/msaGaugeRR.R
Comment on lines 910 to 912
.gaugeVarCompGraph <- function(percentContributionValues, studyVariationValues, percentToleranceValues, Type3 = FALSE) {
sources <- gettext(c('Gauge r&R', 'Repeat', 'Reprod', 'Part-to-part'))
sources <- gettext(c("Gauge r&R", "Repeatability", "Reproducibility", "Part-to-part"))
if (!all(is.na(percentToleranceValues))) {
juliuspfadt
juliuspfadt requested changes Jul 3, 2026
View reviewed changes

@juliuspfadt juliuspfadt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new comments seem kind of valid... sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@juliuspfadt juliuspfadt juliuspfadt requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@JTPetter JTPetter

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Legend text on Components of Variation plot is cut off (does not display completely)

5 participants

@JTPetter @codecov-commenter @juliuspfadt @tomtomme