Skip to content

Gauge RR flooring issue#471

Open
JTPetter wants to merge 3 commits into
jasp-stats:masterfrom
JTPetter:gaugeRounding
Open

Gauge RR flooring issue#471
JTPetter wants to merge 3 commits into
jasp-stats:masterfrom
JTPetter:gaugeRounding

Conversation

@JTPetter

@JTPetter JTPetter commented May 8, 2026

Copy link
Copy Markdown
Contributor

@codecov-commenter

codecov-commenter commented May 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.96%. Comparing base (8c33634) to head (bf97d93).

Files with missing lines Patch % Lines
R/msaGaugeRR.R 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #471      +/-   ##
==========================================
- Coverage   84.96%   84.96%   -0.01%     
==========================================
  Files          18       18              
  Lines       10012    10014       +2     
==========================================
+ Hits         8507     8508       +1     
- Misses       1505     1506       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes Gauge r&R crossed-model variance component calculations when negative component estimates are floored to 0, ensuring reproducibility (reprod) is computed from the floored components rather than from pre-flooring values.

Changes:

  • Recomputes reprod after applying max(0, ...) to operator and (when present) interaction.
  • Ensures interaction is floored before contributing to reprod in the interaction case.

Comment thread R/msaGaugeRR.R
@juliuspfadt

Copy link
Copy Markdown
Contributor

build builder bot build for glory

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

✅ Build Complete!

Your JASP module bundles have been successfully built for macOS (ARM) and Windows.

👉 Click here to download the artifacts

(Scroll to the bottom of the page to find the "Artifacts" section).

@juliuspfadt

Copy link
Copy Markdown
Contributor

the issue is indeed fixed. however I was being stupid with some variable assignment and found a bug:
MSA Polymer.jasp.zip
Screenshot 2026-07-01 at 15 26 32

@juliuspfadt juliuspfadt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see the error
also can you address the copilot feedback?

@JTPetter

JTPetter commented Jul 3, 2026

Copy link
Copy Markdown
Contributor Author

thanks, done!

@JTPetter JTPetter requested a review from juliuspfadt July 3, 2026 14:55
@juliuspfadt

Copy link
Copy Markdown
Contributor

build builder bot build for glory

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 54 changed files in this pull request and generated 1 comment.

@@ -0,0 +1,25 @@
Appraiser,Lot,Measured Part,Response,Part

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no fix.

@github-actions

github-actions Bot commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

✅ Build Complete!

Your JASP module bundles have been successfully built for macOS (ARM) and Windows.

👉 Click here to download the artifacts

(Scroll to the bottom of the page to find the "Artifacts" section).

@juliuspfadt juliuspfadt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants