DoE Analysis: Factorial and Interaction plots#470
Open
JTPetter wants to merge 4 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #470 +/- ##
==========================================
- Coverage 84.96% 84.89% -0.08%
==========================================
Files 18 18
Lines 10012 10332 +320
==========================================
+ Hits 8507 8771 +264
- Misses 1505 1561 +56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Comment on lines
+2012
to
+2013
| stop(gettextf("Error computing emmeans for terms '%s': %s. Prediction fallback failed: %s.", | ||
| paste(termNames, collapse = ", "), conditionMessage(e), conditionMessage(e2))) |
Contributor
|
build bot build |
Contributor
✅ Build Complete!Your JASP module bundles have been successfully built for macOS (ARM) and Windows. 👉 Click here to download the artifacts (Scroll to the bottom of the page to find the "Artifacts" section). |
JohnnyDoorn
requested changes
Jul 3, 2026
JohnnyDoorn
left a comment
JohnnyDoorn
left a comment
Contributor
There was a problem hiding this comment.
- the placeholder plot shows when loading the analysis, which shouldn't be the case
- the options could be laid out across 2 columns
- For the interaction plots, would it maybe increase the clarity of the figures if you work with faded colors for the confidence bands, similar to the other descriptives plots in JASP? They currently do look nice and funky, but it's not so easy to get a clear idea of the interactions.
- the plots appear in the top, changing the plots triggers the main results which is probably not what is needed.
- to plot the interaction for continuous predictors there is some stratifying going on that can create messy labels - maybe you can take a look at how it's done in regression for stratifying continuous predictors: jasp-stats/jaspRegression#514
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.