Skip to content

adjust output from plotly for jaspBase #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vandenman wants to merge 1 commit into
base: master
Choose a base branch
from
Open

adjust output from plotly for jaspBase #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/convertGgplotToPlotly.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ convertGgplotToPlotly <- function(ggplotObj, returnJSON = TRUE) {
json <- toJSON(list(data = converted$plotly$x$data, layout = converted$plotly$x$layout, hasRangeFrame = converted$hasRangeFrame))
json
} else {
converted$plotly
converted
}
})
return(e)
Expand Down
27 changes: 14 additions & 13 deletions tests/testthat/test-convertGgplotToPlotly.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,14 @@ test_that("convertGgplotToPlotly: structural conversion to plotly object", {

p <- ggplot2::qplot(1:10, rnorm(10)) + themeJaspRaw()

# confirm it converts and returns a plotly-like object
# confirm it converts and returns the structured plotly conversion
res <- convertGgplotToPlotly(p, returnJSON = FALSE)
testthat::expect_true(inherits(res, "plotly"))
testthat::expect_true(inherits(res$plotly, "plotly"))

# basic structural checks: traces should be present and layout exists
expect_true(length(res$x$data) >= 1)
expect_true(!is.null(res$x$layout))
expect_true(length(res$plotly$x$data) >= 1)
expect_true(!is.null(res$plotly$x$layout))
expect_false(is.null(res$hasRangeFrame))

# also ensure ggplotly yields similar structure (non-image test)
res2 <- plotly::ggplotly(p)
Expand All @@ -35,27 +36,27 @@ test_that("convertGgplotToPlotly: jaspMatrixPlot conversion preserves matrix lay
p <- ggMatrixPlot(plotMatrix)
res <- convertGgplotToPlotly(p, returnJSON = FALSE)

testthat::expect_true(inherits(res, "plotly"))
testthat::expect_true(inherits(res$plotly, "plotly"))

xaxes <- grep("^xaxis", names(res$x$layout), value = TRUE)
yaxes <- grep("^yaxis", names(res$x$layout), value = TRUE)
xaxes <- grep("^xaxis", names(res$plotly$x$layout), value = TRUE)
yaxes <- grep("^yaxis", names(res$plotly$x$layout), value = TRUE)
testthat::expect_equal(length(xaxes), prod(dim(p$plotArgs$layout)))
testthat::expect_equal(length(yaxes), prod(dim(p$plotArgs$layout)))

xWidths <- unique(round(vapply(xaxes, function(ax) diff(res$x$layout[[ax]]$domain), numeric(1L)), 2L))
yHeights <- unique(round(vapply(yaxes, function(ax) diff(res$x$layout[[ax]]$domain), numeric(1L)), 2L))
xWidths <- unique(round(vapply(xaxes, function(ax) diff(res$plotly$x$layout[[ax]]$domain), numeric(1L)), 2L))
yHeights <- unique(round(vapply(yaxes, function(ax) diff(res$plotly$x$layout[[ax]]$domain), numeric(1L)), 2L))
testthat::expect_gt(length(xWidths), 1L)
testthat::expect_gt(length(yHeights), 1L)
testthat::expect_true(length(res$x$layout$shapes) > 0L)
testthat::expect_true(length(res$plotly$x$layout$shapes) > 0L)

annotations <- res$x$layout$annotations
annotations <- res$plotly$x$layout$annotations
testthat::expect_false(is.null(annotations))
testthat::expect_true(any(vapply(annotations, function(annotation) identical(annotation$textangle, -90), logical(1L))))

p_shared <- ggMatrixPlot(plotMatrix, shareX = TRUE, shareY = TRUE)
res_shared <- convertGgplotToPlotly(p_shared, returnJSON = FALSE)
xaxes_shared <- grep("^xaxis", names(res_shared$x$layout), value = TRUE)
yaxes_shared <- grep("^yaxis", names(res_shared$x$layout), value = TRUE)
xaxes_shared <- grep("^xaxis", names(res_shared$plotly$x$layout), value = TRUE)
yaxes_shared <- grep("^yaxis", names(res_shared$plotly$x$layout), value = TRUE)
testthat::expect_lt(length(xaxes_shared), length(xaxes))
testthat::expect_lt(length(yaxes_shared), length(yaxes))
})
Loading