Add dedicated Number of Factors/Components analysis#359
Open
juliuspfadt wants to merge 4 commits into
Open
Conversation
Contributor
|
👋 Friendly reminder: It looks like If your changes include bug fixes, new features, or UI tweaks, please consider adding a quick note to the |
…s analysis - new analysis numberOfFactors: parallel analysis (PC/FA), eigenvalue threshold, summary table, PA table, scree plot; fa.parallel runs once, cached in state - EFA/PCA: retention reduced to manual IntegerField; PA table + scree plot options removed; dead code deleted - Upgrades.qml: remove stale options, msg pointing to new analysis - tests: PA/scree tests moved to test-numberoffactors.R; EFA/PCA tests use explicit manual counts (values unchanged); PA sim values need regeneration on first run (single fa.parallel call changes RNG path) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…actor count - PA sim values + suggestion regenerated (single seeded fa.parallel run) - orderLoadingsBy test: manualNumberOfFactors = 3 (was PA default) - new snapshot scree-plot-pc.svg (needs manual inspection) Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
juliuspfadt
force-pushed
the
feature/number-of-factors-analysis
branch
from
9cf6ee5 to
832dad6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New analysis: Number of Factors/Components
Consolidates parallel analysis (PC- and FA-based), the eigenvalue criterion, and the scree plot into one dedicated analysis, usable for both EFA and PCA decisions.
Provides a summary table with suggested retention numbers from each method side-by-side.
The eigenvalue/PA-based factor count options are removed from both analyses. The number of factors/components is now set manually, with an info tip pointing users to the new analysis.
This removes the ambiguity of running a full factor model and factor retention simultaneously.
fixes [Feature Request]: Document if the Eigenvalue criterion is based on the principal component jasp-issues#3970:
Previously the eigenvalue criterion always used PC eigenvalues (pc.values), even when FA-based parallel analysis was selected. This caused confusing results in EFA where factors with factor eigenvalues < 1 were retained because the threshold was applied to PC eigenvalues.
Now the eigenvalue criterion uses PC eigenvalues when PC-based PA is selected and factor eigenvalues when FA-based PA is selected.
A footnote on the summary table states which eigenvalue type was used (e.g., "Eigenvalue criterion based on factor eigenvalues.").
The info text for the threshold field explains the link to the PA method selection.
For testing:
test.jasp.zip