Skip to content

fix: add error level handling to ErrorMessage class and constructor #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
janole merged 5 commits into from
Sep 22, 2025
Merged

fix: add error level handling to ErrorMessage class and constructor #41

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0db6f62
fix: add error level handling to ErrorMessage class and constructor
janole Sep 22, 2025
adea269
feat: add addError method to append error messages in ChatSession
janole Sep 22, 2025
3954ed1
fix: replace console.error with addError for session save failure log…
janole Sep 22, 2025
5a5db30
fix: provide correct error level to ErrorMessage constructor instance…
janole Sep 22, 2025
136873a
refactor: remove addError method and inline error message addition in…
janole Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/ai/custom-messages.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export abstract class CustomMessage
{
if (obj._type === "error")
{
return new ErrorMessage(obj.content, obj.error);
return new ErrorMessage(obj.content, obj.level, obj.error);
}
else if (obj._type === "tool-progress")
{
Expand All @@ -41,18 +41,20 @@ export abstract class CustomMessage
class ErrorMessage extends CustomMessage
{
content: string;
level: "debug" | "warn" | "error";

error?: {
name: string;
message: string;
stack?: string;
};

constructor(content: string, error?: Error | ErrorMessage["error"])
constructor(content: string, level: ErrorMessage["level"] = "error", error?: Error | ErrorMessage["error"])
{
super("error");

this.content = content;
this.level = level;

if (error)
{
Expand Down Expand Up @@ -201,3 +203,4 @@ export
setMessageIsStreaming,
ToolProgressMessage,
};

5 changes: 4 additions & 1 deletion src/ai/session/session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,10 @@ export class ChatSession implements IChatSession
})
.catch((error) =>
{
console.error("ERROR: Session save failed!", error);
this.setMessages([
...this.messages,
new ErrorMessage("Saving session failed", "error", error)
]);
});

return this._saveQueue;
Expand Down
6 changes: 3 additions & 3 deletions src/ai/work.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ async function work(props: WorkProps)

if (!stream)
{
messages.push(new ErrorMessage(`ERROR: ${error?.message || error?.toString() || "llm.stream(...) failed."}`, error));
messages.push(new ErrorMessage(`ERROR: ${error?.message || error?.toString() || "llm.stream(...) failed."}`, "error", error));
return messages;
}

Expand Down Expand Up @@ -63,7 +63,7 @@ async function work(props: WorkProps)

if (!result || error)
{
messages.push(new ErrorMessage(`ERROR: ${error?.message || error?.toString() || "llm.generate(...) failed."}`, error));
messages.push(new ErrorMessage(`ERROR: ${error?.message || error?.toString() || "llm.generate(...) failed."}`, "error", error));
return messages;
}

Expand Down Expand Up @@ -201,7 +201,7 @@ function addFailedToolCallMessage(error: string | Error, toolCall: { id?: string
}
else
{
messages.push(new ErrorMessage(content, (error instanceof Error) ? error : undefined));
messages.push(new ErrorMessage(content, "error", (error instanceof Error) ? error : undefined));
}
}

Expand Down