Skip to content

[2653] Do not use the java.version system property when attempting to…#2654

Merged
scottmarlow merged 1 commit intojakartaee:mainfrom
jamezp:issue2653
Apr 10, 2026
Merged

[2653] Do not use the java.version system property when attempting to…#2654
scottmarlow merged 1 commit intojakartaee:mainfrom
jamezp:issue2653

Conversation

@jamezp
Copy link
Copy Markdown
Member

@jamezp jamezp commented Mar 27, 2026

… determine the Java version. Instead use the Runtime.version() in the Jakarta Tags TCK.

Fixes Issue
fixes #2653

Describe the change
Uses the Runtime.vesion() to determine the JVM version rather than the java.version system property.

… determine the Java version. Instead use the Runtime.version() in the Jakarta Tags TCK.

Signed-off-by: James R. Perkins <jperkins@ibm.com>
@pnicolucci
Copy link
Copy Markdown
Member

I'm ok with this change, see the following comment for details: #2653 (comment)

@pnicolucci
Copy link
Copy Markdown
Member

@scottmarlow, for EE12, we're removing the tags TCK from the platform-tck, right? Should this instead be a PR against: https://github.com/jakartaee/tags? Do we need a PR to remove the tags tck from the platform-tck for EE12? I know there was some discussion here: jakartaee/tags#270

@scottmarlow
Copy link
Copy Markdown
Member

scottmarlow commented Apr 1, 2026

@scottmarlow, for EE12, we're removing the tags TCK from the platform-tck, right?

Oh right, thanks for the reminder! We already moved Tags tests over to https://github.com/jakartaee/tags/tree/main/tck/src/main/java/com/sun/ts/tests/jstl so 👍

Should this instead be a PR against: https://github.com/jakartaee/tags?

Yes!

Do we need a PR to remove the tags tck from the platform-tck for EE12?

Yes

I know there was some discussion here: jakartaee/tags#270

👍

@scottmarlow scottmarlow merged commit 1d12087 into jakartaee:main Apr 10, 2026
2 of 3 checks passed
@scottmarlow
Copy link
Copy Markdown
Member

Merging even though the Tags TCK source has been moved to the Tags spec repo.

@jamezp
Copy link
Copy Markdown
Member Author

jamezp commented Apr 10, 2026

FYI I created the upstream PR jakartaee/tags#287.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

12.0 Jakarta EE 12 Platform challenge TCK challenge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The Tags TCK checks the java.version property assuming there will always be a . in the version.

3 participants