Skip to content

Rename TCK client classes / TCK compatibility with h2#1156

Merged
gavinking merged 3 commits into
jakartaee:mainfrom
gavinking:rename-tck-client-classes
Jul 5, 2026
Merged

Rename TCK client classes / TCK compatibility with h2#1156
gavinking merged 3 commits into
jakartaee:mainfrom
gavinking:rename-tck-client-classes

Conversation

@gavinking

Copy link
Copy Markdown
Member

This PR does two things:

  1. Robotically renames all the millions of Client classes to more identifiable names.
  2. Improves execution of the TCK on h2.

@gavinking gavinking marked this pull request as ready for review July 3, 2026 19:49
@gavinking gavinking requested a review from marko-bekhta July 3, 2026 19:49

@marko-bekhta marko-bekhta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll admit that I haven't checked each new calss name 🙂 but it all looks ok in general. 👍🏻 🙂

btw the rename changed the execution order and I think it uncovered an issue with classloading -- looking into that one..

oh and do you think we should make the tck passable on h2 in general ? (I suspect some tests related to stored procedures might not work right now...)

@gavinking

Copy link
Copy Markdown
Member Author

I think it uncovered an issue with classloading -- looking into that one..

Oh, OK, thanks!

oh and do you think we should make the tck passable on h2 in general?

I got all tests passing on h2 except the SP tests. I doubt there's any reasonable way to get them working on h2.

@gavinking gavinking force-pushed the rename-tck-client-classes branch from da0d13f to ba4ec42 Compare July 5, 2026 08:27
@gavinking gavinking merged commit 2ea5a89 into jakartaee:main Jul 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants