Rename TCK client classes / TCK compatibility with h2#1156
Merged
Conversation
marko-bekhta
approved these changes
Jul 4, 2026
marko-bekhta
left a comment
Member
There was a problem hiding this comment.
I'll admit that I haven't checked each new calss name 🙂 but it all looks ok in general. 👍🏻 🙂
btw the rename changed the execution order and I think it uncovered an issue with classloading -- looking into that one..
oh and do you think we should make the tck passable on h2 in general ? (I suspect some tests related to stored procedures might not work right now...)
Member
Author
Oh, OK, thanks!
I got all tests passing on h2 except the SP tests. I doubt there's any reasonable way to get them working on h2. |
da0d13f to
ba4ec42
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does two things:
Clientclasses to more identifiable names.