fix: use PathSpec gitignore parser to remove deprecation warnings#142
Closed
shuofengzhang wants to merge 1 commit into
Closed
fix: use PathSpec gitignore parser to remove deprecation warnings#142shuofengzhang wants to merge 1 commit into
shuofengzhang wants to merge 1 commit into
Conversation
Signed-off-by: shuofengzhang <sofuncheung16@gmail.com>
|
This pull request has been marked as stale due to 7 days of inactivity. Please remove the stale label or comment to keep it open, otherwise, it will be closed in 3 days. |
Owner
|
@shuofengzhang would you kindly please commit using a verified signature |
|
This pull request has been marked as stale due to 7 days of inactivity. Please remove the stale label or comment to keep it open, otherwise, it will be closed in 3 days. |
jahwag
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
gitwildmatchtogitignorein three places insrc/claudesync/utils.py:.gitignoreloadingget_local_files.claudeignoreloadingpyproject.tomlfrom0.7.6to0.7.7(per project contribution requirements).Why
gitwildmatchand emit warnings recommendinggitignore.gitignorekeeps matching behavior aligned with Git ignore semantics while removing avoidable deprecation noise during test runs.Testing
scripts/clone_and_test.sh jahwag/ClaudeSync(pass)source .venv/bin/activate && pytest -q(28 passed)