fix(tray): reset icon to idle when transcription yields empty text#69
Merged
fix(tray): reset icon to idle when transcription yields empty text#69
Conversation
When Whisper produced no usable text (silence, short audio, or hallucination filtering), the TranscriptionDone message was never sent, leaving the tray icon stuck in the yellow Transcribing state. Always send the message so on_transcription_done can transition back to Idle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fix
Removed the empty-text guards in both the in-memory and file-backed transcription paths so
TranscriptionDoneis always sent. The existingon_transcription_donehandler already handles empty text correctly — it skips text insertion and resets the tray to Idle.