fix(runtime): prevent orphaned copilot processes on shutdown#223
Merged
fix(runtime): prevent orphaned copilot processes on shutdown#223
Conversation
spawnAgent() in agent-launcher creates detached+unref child processes for copilot CLI invocations but did not register them with the framework process tracker. When the runtime shut down (or the terminal was killed), killAllActiveProcesses() could not reach these children, leaving them running indefinitely. - Call trackProcess(child) after spawn in spawnAgent() so copilot children are cleaned up by killAllActiveProcesses() on shutdown - Add SIGHUP handler alongside SIGINT/SIGTERM in setupShutdownHandlers() so terminal-close scenarios trigger the same cleanup path - Update shutdown handler test to verify SIGHUP registration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When the AAMF runtime is terminated (e.g. terminal killed, SIGHUP), copilot CLI agent processes are left running as orphans. In one observed case, 55 copilot processes survived after killing the migration terminal.
Root cause (two issues):
Copilot children not tracked for cleanup.
spawnAgent()inagent-launcher.tsspawns copilot CLI processes with{ detached: true }andchild.unref(), making them independent of the parent Node process. However, these children were not registered with the framework'strackProcess()mechanism. The shutdown handler callskillAllActiveProcesses(), but that only kills tracked processes — the copilot agents were invisible to it.No SIGHUP handler. The runtime handles
SIGINTandSIGTERMbut notSIGHUP. When a terminal is closed/killed, the OS sendsSIGHUP. Without a handler, the Node process dies without running cleanup, and detached children survive unconditionally.Fix
trackProcess(child)immediately after spawn inspawnAgent()so copilot CLI processes are registered with the framework process tracker and cleaned up bykillAllActiveProcesses()on shutdown.process.on('SIGHUP', ...)insetupShutdownHandlers()alongsideSIGINT/SIGTERMso terminal-close scenarios trigger the same graceful shutdown path.Changes
src/core/agent-launcher.tstrackProcess, call it after copilot child spawnsrc/core/runtime.tsSIGHUPhandler insetupShutdownHandlers()tests/core/runtime.test.tsSIGHUPregistrationTesting
tsc --noEmitclean