init: Remove agent-mode and log-file defaults from questionnaire#15
Closed
iyaki wants to merge 1 commit into
Closed
init: Remove agent-mode and log-file defaults from questionnaire#15iyaki wants to merge 1 commit into
iyaki wants to merge 1 commit into
Conversation
The ralph init command now always shows NO default for agent-mode and log-file fields in the interactive questionnaire, even when an existing config file contains these values. This ensures users explicitly choose whether to set these optional fields on each run. Changes: - seedInitStringDefaults(): Intentionally omit AgentMode and LogFile from seeding while keeping other string fields (Model, SpecsDir, etc.) - Tests updated to reflect new behavior where these fields remain empty - Added tests for AskQuestions, askSingleQuestion, and exported test helpers to maintain 95%+ coverage requirement Other fields continue to preserve their existing config values as defaults. Logging questions (truncate?) only appear when user provides non-empty log path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per the requirement, the
ralph initcommand now always shows NO default foragent-modeandlog-filefields in the interactive questionnaire, even when an existing config file contains these values.Changes
seedInitStringDefaults()to intentionally omitAgentModeandLogFilefrom seedingTesting
✅ All existing tests pass
✅ Updated
TestSeedInitStringDefaultsto validate fields are NOT seeded✅ Updated
TestInitCommandSeedsQuestionDefaultsFromExistingConfigto reflect new behaviorBehavior
Before: Existing config values for
agent-modeandlog-filewere shown as defaultsAfter: These fields always show empty/no default; logging questions only appear when user provides non-empty log path
Other fields (
model,specs-dir, etc.) continue to show their existing values as defaults.