fix(mantenibilidad): eliminar 2 warnings de deuda técnica#13
Merged
Conversation
…ofing) Cierre de #8. La red de seguridad (smoke tests de generadores) destapó 2 warnings reales — ahora corregidos, con los tests como guard: 1. gen_excel_eme: midagri.groupby("DEPARTAMENTO").apply(...) emitía FutureWarning de pandas (apply operando sobre la columna de agrupación, deprecado en pandas>=2.2 → rompería en una versión futura). Fix: include_groups=False. Verificado seguro: _build_district_text solo usa PROVINCIA/DISTRITO, no DEPARTAMENTO, así que excluir la columna de grupo no cambia el resultado. 2. data_processor.get_departamento_data: df_depto era un slice y al agregarle la columna "_fecha" emitía SettingWithCopyWarning (code smell que puede hacer que la escritura no surta efecto). Fix: .copy() explícito al filtrar. Sin cambios de comportamiento (smoke tests + dept tests verdes). La suite pasa de "51 passed, 2 warnings" a "51 passed" limpio. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cierra #8: la red de seguridad destapó 2 warnings reales. Fix del groupby.apply deprecado de pandas (include_groups=False, verificado seguro) y del SettingWithCopyWarning en get_departamento_data (.copy() explícito). Sin cambio de comportamiento; suite pasa a 51 passed limpio.
🤖 Generated with Claude Code