Allow json mapping usage#16
Open
NathanMolinier wants to merge 21 commits into
Open
Conversation
Member
|
Can you please provide an example of these JSON sidecars? |
Author
|
I updated my original comment with some complimentary information @valosekj |
Member
|
Thank you, Nathan! I understand it now. Thanks for implementing this feature! |
Member
|
Note: CI and unit tests are currently failing due to #18 |
Member
bbc3a00 to
0a34add
Compare
Member
|
Okay, @mguaypaq and I did an interactive rebase ( |
…ricsReloaded into nm/allow_json_mapping_usage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR, 2 new parser variables were integrated
-ref-mapand-pred-map. They both point to JSON sidecars that can be used to remap values present inside the corresponding reference and prediction images.This is especially useful when values between the prediction and the ground truth are not the same and also to simply remove some structures from the comparison.
JSON example:
{ "T12":32, "T12-L1":91, "L1":41, "L1-L2":92, "L2":42, "L2-L3":93, "L3":43, "L3-L4":94, "L4":44, "L4-L5":95, "L5":45, "L5-S":100 }Note: It can also be used to compute validation on a single structure present in the image whereas multiple other structures may appear:
For example:
{ "lesion":2 }This way we could get rid of these lines:
MetricsReloaded/compute_metrics_reloaded.py
Lines 160 to 163 in 2bad1f2
Final table