Skip to content

Initialize Regex Cache By Default#4

Draft
its-hammer-time wants to merge 1 commit intoperf/fix-parameter-schema-cachefrom
default-regex-cache
Draft

Initialize Regex Cache By Default#4
its-hammer-time wants to merge 1 commit intoperf/fix-parameter-schema-cachefrom
default-regex-cache

Conversation

@its-hammer-time
Copy link
Owner

Benchmark Metric Before After Change
GET_Simple time 21,205 ns/op 4,573 ns/op -78.5%
GET_Simple memory 23,833 B/op 4,687 B/op -80.3%
GET_Simple allocs 400 115 -71.3%
GET_WithQueryParams time 18,101 ns/op 5,701 ns/op -68.7%
GET_WithQueryParams memory 16,900 B/op 6,153 B/op -63.6%
RegexFallback_All time 39,021 ns/op 5,387 ns/op -86.2%
RegexFallback_All memory 70,431 B/op 4,874 B/op -93.1%
BulkActions_Small memory 21,126 B/op 12,116 B/op -42.7%
BulkActions_Medium memory 42,807 B/op 33,792 B/op -21.1%
Init (AdsAPI) time 35ms 36ms +3% (one-time)
Geomean all -- -- -34% time, -43% memory, -36% allocs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant